feat!: Use 32-bit vector_math #3405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
reviewed
Dec 14, 2024
renancaraujo
force-pushed
the
renan/vecmath_32
branch
from
bc45d50 to
66e4886
Compare
7 tasks
renancaraujo
force-pushed
the
renan/vecmath_32
branch
from
66e4886 to
5465585
Compare
renancaraujo
force-pushed
the
renan/vecmath_32
branch
from
5465585 to
31ce674
Compare
spydon
pushed a commit
to flame-engine/forge2d
that referenced
this pull request
Dec 14, 2024
# Description Related to flame-engine/flame#3405 ## Checklist <!-- Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. --> - [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc). - [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs. - [x] I have updated/added tests for ALL new/updated/fixed functionality. - [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`. - [x] I have updated/added relevant examples in `examples`. ## Breaking Change <!-- Does your PR require Flame users to manually update their apps to accommodate your change? If the PR is a breaking change this should be indicated with suffix "!" (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details. --> - [x] Yes, this is a breaking change. - [ ] No, this is *not* a breaking change. ## Related Issues <!-- Provide a list of issues related to this PR from the [issue database]. Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !--> <!-- Links --> [issue database]: https://github.com/flame-engine/flame/issues [Contributor Guide]: https://github.com/flame-engine/flame/blob/main/CONTRIBUTING.md [Flame Style Guide]: https://github.com/flame-engine/flame/blob/main/STYLEGUIDE.md [Conventional Commit]: https://conventionalcommits.org
renancaraujo
force-pushed
the
renan/vecmath_32
branch
3 times, most recently
from
b4ef4ba to
3f2d769
Compare
renancaraujo
force-pushed
the
renan/vecmath_32
branch
2 times, most recently
from
abc06cc to
61c83c6
Compare
renancaraujo
force-pushed
the
renan/vecmath_32
branch
from
7d8a1d0 to
9a08369
Compare
|
After changing the imports across the board, i think we should not merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to 32-bit vector_math to not have to not have incompatible types with 3D and shader code.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
#3406